bpo-38191: Accept arbitrary keyword names in NamedTuple() and TypedDict(). by serhiy-storchaka · Pull Request #16222 · python/cpython

serhiy-storchaka · 2019-09-17T09:31:46Z

This includes such names as "cls", "self", "typename", "_typename",
"fields" and "_fields".
Passing positional arguments by keyword is deprecated.

https://bugs.python.org/issue38191

…ct(). This includes such names as "cls", "self", "typename", "_typename", "fields" and "_fields". Passing positional arguments by keyword is deprecated.

pablogsal

LGTM. Thanks, Serhiy for working on this!

If I understand correctly, the next step is to use PEP570 notation on master, right?

serhiy-storchaka · 2019-09-17T16:34:01Z

Yes, and drop this ugly boilerplate code.

gvanrossum

What deprecation schedule do you propose? Can we start using '/' in 3.9? In 3.8?

@ilevkivskyi Maybe this version should be upstreamed (downstreamed?) to github.com/python/typing?

gvanrossum · 2019-09-17T16:50:49Z

@@ -0,0 +1,4 @@
+Constructors of :class:`~typing.NamedTuple` and :class:`~typing.TypedDict`
+types accept now arbitrary keyword argument names, including "cls", "self",


"now accept"

serhiy-storchaka · 2019-09-17T17:56:45Z

3.7 -- no deprecation (but arbitrary keywords supported)
3.8 -- deprecation
3.9 -- use '/'

I think a chance to break somebody's code is small, so we can use a short deprecation period. But there is still a risk, and we do not want to break working code at this stage of 3.8.

miss-islington · 2019-09-17T18:22:04Z

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

…ct(). (pythonGH-16222) This includes such names as "cls", "self", "typename", "_typename", "fields" and "_fields". Passing positional arguments by keyword is deprecated. (cherry picked from commit 2bf31cc) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>

bedevere-bot · 2019-09-17T18:22:14Z

GH-16237 is a backport of this pull request to the 3.8 branch.

miss-islington · 2019-09-17T18:22:15Z

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 2bf31ccab3d17f3f35b42dca97f99576dfe2fc7d 3.7

…ypedDict(). (pythonGH-16222) This includes such names as "cls", "self", "typename", "_typename", "fields" and "_fields". Passing positional arguments by keyword is deprecated.. (cherry picked from commit 2bf31cc) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>

…ct(). (GH-16222) This includes such names as "cls", "self", "typename", "_typename", "fields" and "_fields". Passing positional arguments by keyword is deprecated. (cherry picked from commit 2bf31cc) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>

bedevere-bot · 2019-09-17T18:42:25Z

GH-16239 is a backport of this pull request to the 3.7 branch.

…16222) (GH-16239) This includes such names as "cls", "self", "typename" and "fields". (cherry picked from commit 2bf31cc)

ilevkivskyi · 2019-09-18T12:58:21Z

Maybe this version should be upstreamed (downstreamed?) to github.com/python/typing?

Yes, I think so. Also probably the signatures in typeshed should be updated.

gvanrossum · 2019-09-18T16:32:17Z

Also probably the signatures in typeshed should be updated.

I'm not sure -- are those signatures even used, given the special-casing of TypedDict and NamedTuple?

ilevkivskyi · 2019-09-18T16:37:27Z

I'm not sure -- are those signatures even used, given the special-casing of TypedDict and NamedTuple?

Mypy only uses signature of NamedTuple, but other tools may use them in a different manner, see also python/typeshed#3235

Fixes #677 This backports python/cpython#16222 (Python 3 only). The Python 2 backport is more tricky so I skip it for now.

Fixes python/typing#677 This backports python/cpython#16222 (Python 3 only). The Python 2 backport is more tricky so I skip it for now.

bpo-38191: Accept arbitrary keyword names in NamedTuple() and TypedDi…

20b980b

…ct(). This includes such names as "cls", "self", "typename", "_typename", "fields" and "_fields". Passing positional arguments by keyword is deprecated.

serhiy-storchaka added type-bug An unexpected behavior, bug, or error needs backport to 3.7 labels Sep 17, 2019

serhiy-storchaka requested review from gvanrossum and ilevkivskyi as code owners September 17, 2019 09:31

the-knights-who-say-ni added the CLA signed label Sep 17, 2019

bedevere-bot added the awaiting core review label Sep 17, 2019

pablogsal self-requested a review September 17, 2019 16:12

pablogsal reviewed Sep 17, 2019

View reviewed changes

Comment thread Lib/typing.py Outdated

Add "from None".

fe156a0

pablogsal approved these changes Sep 17, 2019

View reviewed changes

bedevere-bot added awaiting merge and removed awaiting core review labels Sep 17, 2019

gvanrossum approved these changes Sep 17, 2019

View reviewed changes

Update 2019-09-17-12-28-27.bpo-38191.1TU0HV.rst

d33e635

serhiy-storchaka merged commit 2bf31cc into python:master Sep 17, 2019

serhiy-storchaka deleted the typingnamedtuple-new branch September 17, 2019 18:22

bedevere-bot removed the awaiting merge label Sep 17, 2019

bedevere-bot removed the needs backport to 3.8 label Sep 17, 2019

miss-islington assigned serhiy-storchaka Sep 17, 2019

bedevere-bot removed the needs backport to 3.7 label Sep 17, 2019

serhiy-storchaka added a commit that referenced this pull request Sep 17, 2019

[3.7] bpo-38191: Accept arbitrary keyword names in NamedTuple(). (GH-…

69b3718

…16222) (GH-16239) This includes such names as "cls", "self", "typename" and "fields". (cherry picked from commit 2bf31cc)

gvanrossum mentioned this pull request Sep 18, 2019

Backport python/cpython#16222 python/typing#677

Closed

lucasvazq mentioned this pull request Sep 29, 2019

ISSUE: Include TypedDict PEP589 when python 3.8 stable is released lucasvazq/cushead#78

Closed

ilevkivskyi mentioned this pull request Nov 23, 2019

Accept arbitrary keyword names in NamedTuple() and TypedDict() python/typing#686

Merged

ilevkivskyi added a commit to python/typing that referenced this pull request Nov 24, 2019

Accept arbitrary keyword names in NamedTuple() and TypedDict() (#686)

dd00995

Fixes #677 This backports python/cpython#16222 (Python 3 only). The Python 2 backport is more tricky so I skip it for now.

momohatt mentioned this pull request Oct 4, 2020

Unexpected arguments type error python/mypy#8651

Open

serhiy-storchaka removed their assignment Dec 29, 2020

		@@ -0,0 +1,4 @@
		Constructors of :class:`~typing.NamedTuple` and :class:`~typing.TypedDict`
		types accept now arbitrary keyword argument names, including "cls", "self",

Uh oh!

Uh oh!

Conversation

serhiy-storchaka commented Sep 17, 2019 • edited by bedevere-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

pablogsal left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

serhiy-storchaka commented Sep 17, 2019

Uh oh!

gvanrossum left a comment

Choose a reason for hiding this comment

Uh oh!

gvanrossum Sep 17, 2019

Choose a reason for hiding this comment

Uh oh!

serhiy-storchaka commented Sep 17, 2019

Uh oh!

miss-islington commented Sep 17, 2019

Uh oh!

bedevere-bot commented Sep 17, 2019

Uh oh!

miss-islington commented Sep 17, 2019

Uh oh!

bedevere-bot commented Sep 17, 2019

Uh oh!

ilevkivskyi commented Sep 18, 2019

Uh oh!

gvanrossum commented Sep 18, 2019

Uh oh!

ilevkivskyi commented Sep 18, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

serhiy-storchaka commented Sep 17, 2019 •

edited by bedevere-bot

Loading

pablogsal left a comment •

edited

Loading